Write latest master build to downloads.eclipse.org #1060
Conversation
|
@HannesWell wdyt? It's not giving any immediate benefits but it's one more step towards decoupling it from Platform. |
There was a problem hiding this comment.
@HannesWell wdyt? It's not giving any immediate benefits but it's one more step towards decoupling it from Platform.
Regarding this change, the binaries published should probably be jar-signed, shouldn't they?
Once this is in I plan on trying to add this repo in releng.aggregator and have the pde bundles be used from it instead of rebuilt during I-build.
Please don't do that before the cycles are cut. As long as there are other plugins in the SDK that depend on PDE, we should not do that. Otherwise we probably make the situation worse than it is now.
Looking at the Dependencies of pde.build (which is the plugin on that actually every other plugin in PDE depends on) I see mainly the following plugins with PDE dependencies:
- org.eclipse.e4.tools
- org.eclipse.e4.tools.emf.editor3x
- org.eclipse.e4.tools.emf.ui
Plus ant.test.core/ui and jdt.apt.tests.
And having a quick look at that I would say that it is probably possible, but not trivial to change.
See |
akurtakov
force-pushed
the
master
branch
3 times, most recently
from
c4118a5
to
1f03229
Compare
Also done. |
See |
|
@akurtakov now the e4 tools are part of this repo we maybe want to include the features in the updatesite |
Should be done now. |
Using https://download.eclipse.org/pde/builds/master/ as destination so it can be tested more broadly. Mainly motivated to have a permanent download space which wasn't there as discovered in https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4172
Definetly, esp with regards of releases and etc. We are far from such state yet and every step that would make things easier to go to the next step while not causing issue for anything else should be taken. |
|
I don't know yet why but now master build fails :-\ |
|
See #1095 |
|
It still fails even after the test fix is in and this is most likely caused by signing as it fails in the very same way as figured in eclipse-platform/eclipse.platform.releng.aggregator#1673 . |
|
If I fail to figure what's going wrong with comparison in the next few hours I'll revert the signing part only. |
After eclipse-pde#1060 got merged the build failed due to signing. This is similar issue like eclipse-platform/eclipse.platform.releng.aggregator#1673 so this is a simple check whether a "touch" would be enough.
After eclipse-pde#1060 got merged the build failed due to signing. This is similar issue like eclipse-platform/eclipse.platform.releng.aggregator#1673 so this is a simple check whether a "touch" would be enough.
After #1060 got merged the build failed due to signing. This is similar issue like eclipse-platform/eclipse.platform.releng.aggregator#1673 so this is a simple check whether a "touch" would be enough.
Using https://download.eclipse.org/pde/builds/master/ as destination so it can be tested more broadly.
Mainly motivated to have a permanent download space which wasn't there as discovered in
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4172